Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for radio names #348

Merged
merged 3 commits into from
Jan 30, 2018
Merged

Add support for radio names #348

merged 3 commits into from
Jan 30, 2018

Conversation

zinckiwi
Copy link
Contributor

@zinckiwi zinckiwi commented Jan 29, 2018 •
edited
Loading

Per changelog:

EuiRadio now supports the input tag's name attribute. EuiRadioGroup accepts a name prop that will propagate to its EuiRadios.

cjcenizal
cjcenizal approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pugnascotia
pugnascotia approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs the changelog conflict fixing.

@zinckiwi zinckiwi merged commit bf1fe70 into elastic:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pugnascotia pugnascotia pugnascotia approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zinckiwi @cjcenizal @pugnascotia