-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiImage] Fix bug in small images not respecting the optional sizes when allowFullScreen is true #4207
[EuiImage] Fix bug in small images not respecting the optional sizes when allowFullScreen is true #4207
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4207/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This fixes the issue.
The other oddity I noticed is the placement sometimes of the fullScreen and close icons. Because they're being positioned against the entire figure (containing the caption), it doesn't always overlap the image. Perhaps we can just add position:relative
to the button and then move the close icon to be positioned against the window instead of the image.
Preview documentation changes for this PR: https://eui.elastic.co/pr_4207/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4207/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jenkins test this |
1 similar comment
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4207/ |
Summary
This PR closes #4055.
When
allowFullScreen
was set to true the optional sizes were not respected in small images. This PR forces the small images to respect all the optional sizes.How to test
This could be tested by adding this CodeSandbox Example into
src-docs/src/views/image/image_size.js
.Checklist
[ ] Props have proper autodocs[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes