Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] Remove spacer after childrenBetween #4248

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Nov 10, 2020

Closes #4246

When childrenBetween was added, it also added a conditional spacer between it and the search bar (keeping the spacer that existed before the table). The main consumer for needing teh childrenBetween doesn't want this spacer/wants to manually handle this spacing that exists between the children and the table.

This PR, moves the pre-existing spacer to only display if the search bar exists and after the search bar (before the children). So if consumers addd any childrenBetween they will need to add their own spacer between it and the table.

The only possible implications with this change is that it does now make the pre-existing spacer conditional upon the presence of the search bar. So if consumers were using the EuiInMemoryTable without search, it did have a large spacer between the content that came before it which they may have accounted for. But now that space is gone.


I also updated one of the examples to use Facets instead of checkable cards as the more appropriate component.

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • [ ] Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs
  • Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@cchaos cchaos requested a review from thompsongl November 10, 2020 19:22
@cchaos
Copy link
Contributor Author

cchaos commented Nov 10, 2020

cc @pgayvallet

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4248/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good!

+1 to the external state example updates, also

@cchaos cchaos merged commit bb5cc65 into elastic:master Nov 10, 2020
@cchaos cchaos deleted the fix/inMemTable_removeSpace branch November 10, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiInMemoryTable] add the ability to control the spacer's size when using childrenBetween
3 participants