Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(selectable): use latest state in onChange #4292

Merged
merged 1 commit into from
Nov 24, 2020
Merged

fix(selectable): use latest state in onChange #4292

merged 1 commit into from
Nov 24, 2020

Conversation

smhutch
Copy link
Contributor

@smhutch smhutch commented Nov 20, 2020

Summary

Fixes the issue described in #4262. In short, passes the latest component state to the searchProps.onChange callback.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@smhutch smhutch force-pushed the fix-onChange-stale-state branch from 8420dc3 to e453c9e Compare November 20, 2020 14:23
@smhutch smhutch mentioned this pull request Nov 20, 2020
Closed
@thompsongl thompsongl self-requested a review November 20, 2020 15:51
thompsongl
thompsongl reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @smhutch!

Changes look good, but this will also need a "Bugfixes" changelog entry.

@smhutch smhutch force-pushed the fix-onChange-stale-state branch from e453c9e to 827865f Compare November 24, 2020 06:32
@smhutch
Copy link
Contributor Author

smhutch commented Nov 24, 2020

Thanks @thompsongl. I have added the changelog entry now, and rebased into my previous commit. 👍

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4292/

thompsongl
thompsongl approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the help!

@thompsongl thompsongl merged commit 1fdfca2 into elastic:master Nov 24, 2020
@smhutch smhutch deleted the fix-onChange-stale-state branch November 24, 2020 16:32
@chandlerprall chandlerprall mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smhutch @kibanamachine @thompsongl