Fix dropdown styles in Amsterdam #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
commented
Nov 23, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4301/ |
thompsongl
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Changes make sense and code LGTM!
This highlighted for me more discrepancies with how we handle some interactions, so I created #4302. I don't see any reason to block this PR, though.
elizabetdev
approved these changes
Nov 24, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4301/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes some updates to the components of the default theme but shouldn't be any visual changes.
Changed EuiSuperSelect from using EuiPopover with custom styles to EuiInputPopover
This allowed me to remove a lot of placement logic that was already present in EuiInputPopover.
EuiComboBox now uses the same classes as EuiPopover's panel
Instead of duplicating styles and the increase in maintenance, I've copied the
euiPopover__panelclasses onto the EuiPanel within EuiComboBox to help maintain consistency of styles. I've added a comment in the code indicating that in a future re-factor of this component, it should just straight up use the EuiPopover component.Also fixed the scrollbar and extra height issues.
Removed animation from EuiInputPopover (or whenever it is "attached")
This animation was just too much when it would end up connected to the input. So I only added the transition if the
attachedclass doesn't exist.Before
After
Fixed the date picker's dropdown and the datepicker range's input radius
This one was overlooked during the form updates. There's still more work to do on the datepicker itself, but this just fixes the immediate.
Also fixed #4218 by just completely removing the breakpoint that would hide the time select on mobile.
The picker just barely fit on a
320pxwide screen anyway. We'll circle back to better mobile support when we re-write this component.Checklist
[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes