[A11y] Added aria-label to the flyout testenv file
#5702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5702/ |
thompsongl
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
LGTM; Thanks, @yuliacech!
Just the changelog update to remove No public interface changes since 51.0.0.
CHANGELOG.md
Outdated
Comment on lines
2
to
4
| - Updated `testenv` mock for `EuiFlyout` to include default `aria-label` on the close button ([#5702](https://github.com/elastic/eui/pull/5702)) | ||
|
|
||
| No public interface changes since `51.0.0`. |
There was a problem hiding this comment.
Suggested change
| - Updated `testenv` mock for `EuiFlyout` to include default `aria-label` on the close button ([#5702](https://github.com/elastic/eui/pull/5702)) | |
| No public interface changes since `51.0.0`. | |
| - Updated `testenv` mock for `EuiFlyout` to include default `aria-label` on the close button ([#5702](https://github.com/elastic/eui/pull/5702)) |
|
Thank you for the review, @thompsongl! I removed the "no changes" line from the changelog. Waiting on the CI to get green before merging. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5702/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5702/ |
This was referenced Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR only changes
testenvfile of EuiFlyout that produces a mocked version of EuiFlyout. The current mock doesn't have anaria-labelon the close flyout button and causes "critical" a11y violations when an jest-axe test is run against any consuming components in Kibana (see elastic/kibana#127185).Checklist
I don't think any of the items in the checklist are applicable because this PR only touches the mock file.
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes