Font weight fix for k6 #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #568 on the EUI side. Will also require a Kibana PR.
Goes along with elastic/kibana#17467 on the Kibana side.
cc @jen-huang, @cchaos
This was only happening in the K6 theme. In EUI it was happening because we weren't pulling the weights we needed down. In Kibana, the weights are delivered with Kibana, so will need to be manually added. I'll add a separate PR for that.
@cchaos I also upped the medium weight to 600 because
500 wasn't strong enough for the labels500 isn't available in Open Sans, and the 700 was a little too bold. This seemed to be the most consistent value across our themes.EUI native
EUI K6