Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Fix missing cell popover shadows in Safari #6163

Merged
merged 3 commits into from
Aug 23, 2022
Merged

[EuiDataGrid] Fix missing cell popover shadows in Safari #6163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6181c6a
Work around bizarre Safari filter/overflow CSS bug
cee-chen Aug 23, 2022
e57260b
Changelog
cee-chen Aug 23, 2022
5563431
go away sasslint
cee-chen Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/components/datagrid/_data_grid_data_row.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@
max-width: 400px !important;
max-height: 400px !important;
z-index: $euiZDataGridCellPopover !important;
// Workaround for a Safari CSS bug when using both `overflow: auto` & `filter: drop-shadow`
// (see https://github.com/elastic/eui/issues/6151)
// Disables the default EuiPopover filter drop-shadow and uses box-shadow instead,
// since we don't use the popover arrow in any case for cell popovers
filter: none;
// sass-lint:disable-block mixins-before-declarations
@include euiBottomShadow; // TODO: Convert to euiShadowMedium() in Emotion
}

.euiDataGridRowCell__expandFlex {
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6163.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed missing `EuiDataGrid` cell popover shadows in Safari