-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiScreenReaderOnly] Add preventCopy
prop
#6806
Conversation
lol F, this works for Firefox and Safari with richtext paste but not Chrome/Edge (only works on plain paste). 💀 https://bugs.chromium.org/p/chromium/issues/detail?id=1083125 Looks like this might be fixed soon on Chromium's end (fingers crossed) 😬 - rather than trying to do JS shenanigans with |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6806/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the PR and tried out the recommended QA tasks for the EuiScreenReaderOnly
and EuiDataGrid
components. They worked as expected using the keyboard and VoiceOver on Safari.
I'm okay letting this hang out for a bit if you feel Chromium is going to ship a fix soon. I generally like to ship even partial fixes if it improves the experience for users without degrading it for others. In this case, you've improved the experience for Firefox and Safari users, and AFAIK the experience is the same for Chromium.
I'm going to wait for Chromium I think. I guarantee if we release a prop promising to do something that doesn't work quite correctly for the largest market share of browsers, people will be flooding our GitHub issues 😅 |
Excellent point, this ^^. |
…ltiple cells (elastic#6817)" This reverts commit 48c957b.
…nder a hyphenated modifier
- prop order, newlines, typos, etc
Preview documentation changes for this PR: https://eui.elastic.co/pr_6806/ |
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
Removing the stale PR label for now in hopes that Chromium eventually fixes the bug 🤞 |
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
I'm just gonna move this back to draft since Chromium doesn't appear to be resolving the bug anytime soon. 🥲 |
👋 Hey there. This PR hasn't had any activity for 90 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
❌ We're automatically closing this PR due to lack of activity. Please comment if you feel this was done in error. |
Summary
closes #6804
reverts #6817 (
isFocused
workaround should no longer be needed)This PR adds a
preventCopy
prop to EuiScreenReaderOnly, and applies said functionality toEuiDataGrid
to prevent customers copying data from grabbing the SR information about row/column count.I recommend, as always, following along by commit to separate out cleanup tasks.
QA
General checklist
@default
if default values are missing) and playground toggles- [ ] Checked in both light and dark modes- [ ] Checked in mobile- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Updated the Figma library counterpart