Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix EuiMarkdownEditor plugin example polluting other examples #7929

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Jul 29, 2024

Summary

The previous example code was polluting the default link validator plugin, leading to https://eui.elastic.co/v94.2.0/#/editors-syntax/markdown-format#link-validation-for-security incorrectly not parsing http links. This PR fixes the example to use the new exclude configs we added in #7676, and is overall a significantly cleaner approach in any case.

QA

General checklist

N/A, docs only change

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Jul 29, 2024
@cee-chen cee-chen changed the title [Docs] Fix EuiMarkdownEditor plugin polluting other examples [Docs] Fix EuiMarkdownEditor plugin example polluting other examples Jul 29, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@JasonStoltz JasonStoltz marked this pull request as ready for review July 29, 2024 21:32
@JasonStoltz JasonStoltz requested a review from a team as a code owner July 29, 2024 21:32
@cee-chen cee-chen merged commit 27ab9fd into elastic:main Jul 29, 2024
11 checks passed
@cee-chen cee-chen deleted the docs/markdown-link-validation-example branch July 29, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants