Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCodeEditor] Set $blockScrolling = Infinity to prevent console warning #940

Merged

Conversation

ycombinator
Copy link
Contributor

Before this change, this warning would be shown in the console:

Automatically scrolling cursor into view after selection change this will be disabled in the next version set editor.$blockScrolling = Infinity to disable this message

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a quick note to the changelog; while the component interface is unchanged this does modify the editor behaviour.

Without this change, this warning is shown in the console: "Automatically scrolling cursor into view after selection change this will be disabled in the next version set editor.$blockScrolling = Infinity to disable this message"
@ycombinator ycombinator force-pushed the code-editor/block-scrolling-warning branch from 146188d to 31ebc48 Compare June 21, 2018 16:25
@ycombinator
Copy link
Contributor Author

@chandlerprall CHANGELOG entry added. Ready for your 👀 again. Thanks!

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM

@ycombinator ycombinator merged commit 7eeea13 into elastic:master Jun 21, 2018
@ycombinator ycombinator deleted the code-editor/block-scrolling-warning branch June 21, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants