Increase the monitor throughput: increase the default fetch size, make it configurable. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it configurable.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
blakerouse
requested changes
Mar 26, 2021
internal/pkg/config/config.go
Outdated
| @@ -27,13 +27,17 @@ type Config struct { | |||
| Inputs []Input `config:"inputs"` | |||
| Logging Logging `config:"logging"` | |||
| HTTP HTTP `config:"http"` | |||
| Cache Cache `config:"cache"` | |||
There was a problem hiding this comment.
The cache was moved under the input level of the configuration, where it must be for Elastic Agent to be able to adjust these values.
internal/pkg/config/config.go
Outdated
| @@ -27,13 +27,17 @@ type Config struct { | |||
| Inputs []Input `config:"inputs"` | |||
| Logging Logging `config:"logging"` | |||
| HTTP HTTP `config:"http"` | |||
| Cache Cache `config:"cache"` | |||
| Monitor Monitor `config:"monitor"` | |||
There was a problem hiding this comment.
This also needs to be added under the input and not at this top-level.
|
Updated, moved the monitor config into input config. |
blakerouse
approved these changes
Mar 29, 2021
aleksmaus
added a commit
to aleksmaus/fleet-server
that referenced
this pull request
Mar 30, 2021
…e it configurable. (elastic#171) * Increase the monitor throughput: increase the default fetch size, make it configurable. * Address the code review feedback (cherry picked from commit e475479)
aleksmaus
added a commit
to aleksmaus/fleet-server
that referenced
this pull request
Mar 30, 2021
…e it configurable. (elastic#171) * Increase the monitor throughput: increase the default fetch size, make it configurable. * Address the code review feedback (cherry picked from commit e475479)
2 tasks
mergify bot
added a commit
that referenced
this pull request
Mar 30, 2021
…e it configurable. (#171) (#189) * Increase the monitor throughput: increase the default fetch size, make it configurable. * Address the code review feedback (cherry picked from commit e475479) Co-authored-by: Aleksandr Maus <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increases the monitor throughput:
Why is it important?
Tuning of the throughput.
Checklist