Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the monitor long poll timeout to 4 minutes by default #306

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Reduce the monitor long poll timeout to 4 minutes by default #306

merged 1 commit into from
Apr 30, 2021

Conversation

aleksmaus
Copy link
Contributor

What does this PR do?

  • Reduces the monitor long poll timeout to 4 minutes by default
  • Change log message level from Error to Info

Why is it important?

This addresses #304

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related issues

@aleksmaus aleksmaus added enhancement New feature or request Team:Elastic-Agent Label for the Agent team v7.13.0 v7.14.0 candidate-7.14 labels Apr 29, 2021
ruflin
ruflin reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this because of the Cloud proxy timeout?

@ruflin ruflin self-requested a review April 29, 2021 18:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #306 opened

  • Start Time: 2021-04-29T18:21:40.180+0000

  • Duration: 17 min 24 sec

  • Commit: 901be25

Test stats 🧪

Test Results
Failed 0
Passed 117
Skipped 0
Total 117

Trends 🧪

Image of Build Times

Image of Tests

@aleksmaus
Copy link
Contributor Author

LGTM. Is this because of the Cloud proxy timeout?

They do have proxy in between. I asked if reducing timeout to 4 minutes will help.

  • "... 4 minutes or so would probably work well"

@aleksmaus aleksmaus merged commit e19463d into elastic:master Apr 30, 2021
mergify bot pushed a commit that referenced this pull request Apr 30, 2021
@aleksmaus
Reduce the monitor long poll timeout to 4 minutes by default (#306)
5d44763 
(cherry picked from commit e19463d)
@mergify mergify bot mentioned this pull request Apr 30, 2021
Merged
mergify bot pushed a commit that referenced this pull request Apr 30, 2021
@aleksmaus
Reduce the monitor long poll timeout to 4 minutes by default (#306)
bf8273b 
(cherry picked from commit e19463d)
@mergify mergify bot mentioned this pull request Apr 30, 2021
Merged
mergify bot added a commit that referenced this pull request Apr 30, 2021
@mergify @aleksmaus
Reduce the monitor long poll timeout to 4 minutes by default (#306) (#…
994dd6b 
…307)

(cherry picked from commit e19463d)

Co-authored-by: Aleksandr Maus <[email protected]>
mergify bot added a commit that referenced this pull request Apr 30, 2021
@mergify @aleksmaus
Reduce the monitor long poll timeout to 4 minutes by default (#306) (#…
c50580e 
…308)

(cherry picked from commit e19463d)

Co-authored-by: Aleksandr Maus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@scunningham scunningham Awaiting requested review from scunningham

@blakerouse blakerouse Awaiting requested review from blakerouse

Assignees
No one assigned
Labels
candidate-7.14 enhancement New feature or request Team:Elastic-Agent Label for the Agent team v7.13.0 v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message: failed on waiting for global checkpoints advance
3 participants
@aleksmaus @elasticmachine @ruflin