Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send owner: true on API call to invalid API keys. #381

Merged
merged 1 commit into from
May 20, 2021

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Sends owner: true on API call to invalid API keys.

Why is it important?

So API keys can be invalidated when Fleet Server is connected to elasticsearch using the elastic/fleet-server service token.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse self-assigned this May 20, 2021
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #381 opened

  • Start Time: 2021-05-20T14:59:20.715+0000

  • Duration: 5 min 45 sec

  • Commit: 72a086d

Test stats 🧪

Test Results
Failed 0
Passed 174
Skipped 0
Total 174

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakerouse blakerouse merged commit ce31018 into elastic:master May 20, 2021
@blakerouse blakerouse deleted the invalidate-owner-true branch May 20, 2021 15:07
mergify bot pushed a commit that referenced this pull request May 20, 2021
mergify bot pushed a commit that referenced this pull request May 20, 2021
mergify bot added a commit that referenced this pull request May 20, 2021
(cherry picked from commit ce31018)

Co-authored-by: Blake Rouse <[email protected]>
mergify bot added a commit that referenced this pull request May 20, 2021
(cherry picked from commit ce31018)

Co-authored-by: Blake Rouse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidation of API key's fails using service token
3 participants