Configure cache #443
Merged
Configure cache #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
scunningham
force-pushed
the
cfgCache
branch
2 times, most recently
from
e6397a3 to
e4798bc
Compare
added 3 commits
June 10, 2021 10:38
Allow object TTL's to be configurable. Default apikey TTL to 15m to avoid auth bottleneck.
aleksmaus
approved these changes
Jun 10, 2021
| val = "" | ||
| } | ||
|
|
||
| // If enabled, jitter allows us to randomize the expirtion of the artifact |
mergify bot
added a commit
that referenced
this pull request
Jun 10, 2021
* Tweak server timeouts. Limit body size to defend malicious agent (cherry picked from commit f335936) * Refactor bulk init (cherry picked from commit 0cd883a) * Drop cache if configuration changes. Allow object TTL's to be configurable. Default apikey TTL to 15m to avoid auth bottleneck. (cherry picked from commit aadaa4c) Co-authored-by: Sean Cunningham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the TTL values on the cache objects configurable. Allows cache to be reconfigured without restarting the process. Cache is dropped on reconfiguration.
Increate the TTL on the api key to 15m with optional jitter. This is to work around latency issues at scale with validating API . In addition, validate that 'enabled' flag on the agent during auth. Between the 'enabled' flag, and the ability to drop the cache by reconfiguration in a break glass scenario, it seems minimize auth round trips to elastic. This takes load off the fleet-server as well as elastic.
Also, cache the case when an api key is not valid. This avoids roundtrip for an already disabled api key.
Why is it important?
The server runs into issues at large scale while trying to validate many ApiKeys at once. Particularly when a policy changes and there are many GET requests for artifacts.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.