Remove indirect build dependency on go-license-detector. #457
Conversation
The 'go tidy' command in go1.16.5 stripped the hash from go.sum breaking the dependencies-report script. Explictly install the [email protected] script and invoke directly.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
|
If we want to take this approach we'll also need the go-licenser installed in a similar manner. |
|
Open to suggestions. I am having similar issues with the licenser. |
| @@ -42,9 +45,9 @@ clean: ## - Clean up build artifacts | |||
| .PHONY: generate | |||
| generate: ## - Generate schema models | |||
| @printf "${CMD_COLOR_ON} Installing module for go generate\n${CMD_COLOR_OFF}" | |||
| go install github.com/aleksmaus/generate/... | |||
| env GOBIN=${GOBIN} go install github.com/aleksmaus/generate/cmd/schema-generate@latest | |||
There was a problem hiding this comment.
is it in the plan prior to 7.14 to remove alexmaus personal git directory as part of source? @aleksmaus @scunningham ?
There was a problem hiding this comment.
That would be wise. @aleksmaus can handle that when he returns. Also noticed a tool in Andrew Kroh's personal space. Not sure where that came from.
There was a problem hiding this comment.
This was a fork and heavily customized schema code generator for our specific needs.
FWIW, we pull bunch of third party dependencies from other people personal spaces ;-)
Can move it at some point into elastic org sure.
If it works as is, I prefer to merge and iterate since it is blocking the build for all erryone |
Just waiting for a review. Anybody? Beuller? |
* Remove indirect build dependency on go-license-detector. The 'go tidy' command in go1.16.5 stripped the hash from go.sum breaking the dependencies-report script. Explictly install the [email protected] script and invoke directly. * Fix paths for schema generator and license as well. * Properly version URL for schema-generate. (cherry picked from commit 6f636f7)
* Remove indirect build dependency on go-license-detector. The 'go tidy' command in go1.16.5 stripped the hash from go.sum breaking the dependencies-report script. Explictly install the [email protected] script and invoke directly. * Fix paths for schema generator and license as well. * Properly version URL for schema-generate. (cherry picked from commit 6f636f7)
* Remove indirect build dependency on go-license-detector. The 'go tidy' command in go1.16.5 stripped the hash from go.sum breaking the dependencies-report script. Explictly install the [email protected] script and invoke directly. * Fix paths for schema generator and license as well. * Properly version URL for schema-generate. (cherry picked from commit 6f636f7) Co-authored-by: Sean Cunningham <[email protected]>
* Remove indirect build dependency on go-license-detector. The 'go tidy' command in go1.16.5 stripped the hash from go.sum breaking the dependencies-report script. Explictly install the [email protected] script and invoke directly. * Fix paths for schema generator and license as well. * Properly version URL for schema-generate. (cherry picked from commit 6f636f7) # Conflicts: # Makefile
* Remove indirect build dependency on go-license-detector. The 'go tidy' command in go1.16.5 stripped the hash from go.sum breaking the dependencies-report script. Explictly install the [email protected] script and invoke directly. * Fix paths for schema generator and license as well. * Properly version URL for schema-generate. (cherry picked from commit 6f636f7) # Conflicts: # Makefile # NOTICE.txt # go.mod
What does this PR do?
Tweaks the dependencies-report script to explicitly download required version of the go-license-detector tool and invoke it directly. Previous version expected the dependencies to be included in the go module files that it was analyzing. This broke when newer version of 'go tidy' more aggressively strips modules that are not part of the targeted program's dependency tree.
Why is it important?
The release build process invokes the 'dependencies-report' script, which is currently broken.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.