Fix panic caused by Agent check-in when Fleet Server is upgraded from 7.14.0 previous #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scunningham
approved these changes
Aug 31, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
(cherry picked from commit c859cf0)
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
(cherry picked from commit c859cf0)
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2021
(cherry picked from commit c859cf0) Co-authored-by: Blake Rouse <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2021
(cherry picked from commit c859cf0) Co-authored-by: Blake Rouse <[email protected]>
|
Can you please add some tests? |
1 task
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.
When running on previous version of Fleet Server the version of the Elastic Agent was not stored. With 7.15 the version was added, but that means that on check-in it needs to handle the case that the metadata is not present.
How does this PR solve the problem?
// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.
This adds a check to ensure that the metadata is present before checking the version field. If not present then the version will be updated correctly in 7.15 as it should.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues