Build under Go 1.9.2 and other minor fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a device ID of zero (Host device) to FSEventsCopyUUIDForDevice causes the following assertion failure error to be printed to the logs: (FSEvents.framework) FSEventsCopyUUIDForDevice(): failed assertion 'dev > 0'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request incorporates 3 fixes to fsevents:
Fix uint64 overflow during build by remove unnecessary (1 << 64) to kFSEventStreamEventIdSinceNow flag.
Avoid assertion failed error message when requesting a Host Stream (device id = 0).
Fix race condition in channel creation (cherry-picked from Avoid race in channel creation, closes #28 fsnotify/fsevents#29)
Fixes elastic/beats#5783