Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic templates to bulk indexer item #189

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jul 24, 2024

Make bulk request accept dynamic templates by adding DynamicTemplates field to bulk indexer item. This is only added to bulk indexer, not appender.

@obltmachine obltmachine added the safe-to-test Automated label for running bench-diff on forked PRs label Jul 24, 2024
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could we add a small unit test that validates the _bulk request format?

bulk_indexer.go Outdated Show resolved Hide resolved
Co-authored-by: Andrew Wilkins <[email protected]>
@carsonip carsonip marked this pull request as ready for review August 7, 2024 10:25
@carsonip carsonip requested a review from a team as a code owner August 7, 2024 10:26
@carsonip carsonip requested a review from axw August 7, 2024 10:26
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carsonip carsonip merged commit 3e17944 into elastic:main Aug 7, 2024
5 checks passed
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib Aug 13, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/elastic/go-docappender/v2](https://togithub.com/elastic/go-docappender)
| `v2.2.1` -> `v2.3.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2felastic%2fgo-docappender%2fv2/v2.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2felastic%2fgo-docappender%2fv2/v2.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2felastic%2fgo-docappender%2fv2/v2.2.1/v2.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2felastic%2fgo-docappender%2fv2/v2.2.1/v2.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>elastic/go-docappender
(github.com/elastic/go-docappender/v2)</summary>

###
[`v2.3.0`](https://togithub.com/elastic/go-docappender/releases/tag/v2.3.0)

[Compare
Source](https://togithub.com/elastic/go-docappender/compare/v2.2.1...v2.3.0)

##### What's Changed

- build(deps): bump golang.org/x/sync from 0.7.0 to 0.8.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/elastic/go-docappender/pull/192](https://togithub.com/elastic/go-docappender/pull/192)
- Add dynamic templates to bulk indexer item by
[@&#8203;carsonip](https://togithub.com/carsonip) in
[https://github.com/elastic/go-docappender/pull/189](https://togithub.com/elastic/go-docappender/pull/189)

**Full Changelog**:
elastic/go-docappender@v2.2.1...v2.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
f7o referenced this pull request in f7o/opentelemetry-collector-contrib Sep 12, 2024
…lemetry#34642)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/elastic/go-docappender/v2](https://togithub.com/elastic/go-docappender)
| `v2.2.1` -> `v2.3.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2felastic%2fgo-docappender%2fv2/v2.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2felastic%2fgo-docappender%2fv2/v2.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2felastic%2fgo-docappender%2fv2/v2.2.1/v2.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2felastic%2fgo-docappender%2fv2/v2.2.1/v2.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>elastic/go-docappender
(github.com/elastic/go-docappender/v2)</summary>

###
[`v2.3.0`](https://togithub.com/elastic/go-docappender/releases/tag/v2.3.0)

[Compare
Source](https://togithub.com/elastic/go-docappender/compare/v2.2.1...v2.3.0)

##### What's Changed

- build(deps): bump golang.org/x/sync from 0.7.0 to 0.8.0 by
[@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/elastic/go-docappender/pull/192](https://togithub.com/elastic/go-docappender/pull/192)
- Add dynamic templates to bulk indexer item by
[@&open-telemetry#8203;carsonip](https://togithub.com/carsonip) in
[https://github.com/elastic/go-docappender/pull/189](https://togithub.com/elastic/go-docappender/pull/189)

**Full Changelog**:
elastic/go-docappender@v2.2.1...v2.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Automated label for running bench-diff on forked PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants