Add Process.Parent() #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Parent()method toProcessand implements it for all platforms. This should make it easier for users of this library to traverse the process tree.Two other minor changes:
Info()on Darwin. We already do this for Linux and Windows, and now thatParent()is callingInfo()as well it makes even more sense to cache.providers/linux/os_test.go- unlike many other test files that contain_linuxin their names and are thus excluded, this one had been running on Windows as well. At least on my Windows Vagrant machinego test ./...failed because of it.