Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fix crash due to unterminated string #58

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jul 9, 2019

This fixes a crash when fetching a process arguments. The command-line string read from the target process memory sometimes is not terminated. It can cause bogus characters to be appended to the command-line or a crash.

This fixes a crash when fetching a process arguments. The command-line
string read from the target process memory sometimes is not terminated.
It can cause bogus characters appended to the command-line or a crash.
@adriansr adriansr added bug Something isn't working review labels Jul 9, 2019
@adriansr adriansr requested a review from andrewkroh July 9, 2019 10:59
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit 06c1f46 into elastic:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants