Add Linux Networking counters #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
reviewed
Dec 3, 2019
jsoriano
approved these changes
Dec 3, 2019
andrewkroh
reviewed
Dec 4, 2019
| @@ -0,0 +1,12 @@ | |||
| cpu 31608779 223223 15924288 1134746753 223880 4348430 1995355 266903 0 0 | |||
There was a problem hiding this comment.
I don't see where this file is being used in the PR. If it's not used then let's remove it.
There was a problem hiding this comment.
Apparently the code will try and find a /proc/host file before it does anything else. Without this the test will fail.
andrewkroh
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See elastic/beats#12210
Started this before I left for a 4-day weekend so it might be a tad all over, hopefully not.
I fear this is a case of me being a bit too 'clever' since I came up with a way to have one method that populates all of the structs. It would be possible to combine
fillStructandreadAndParseNetFile, but then we would needFieldbyNameas opposed toFieldto get the struct, which means each call would iterate over the structNumField()times asFieldByNamejust iterates until it gets a given name. I would still like to find a better way to do this.Other than that, this is fairly straight forward. The mapping of struct field -> map is because the network counter types are known, but there's basically no documentation on the counters themselves, they're just random kernel fields. I think it would be better to have this library be more neutral, and any editorializing/filtering can be done in metricbeat.
Ah! Still need to update the readme.