Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AIX support #44

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Add AIX support #44

merged 1 commit into from
Apr 1, 2020

Conversation

Helflym
Copy link
Contributor

@Helflym Helflym commented Apr 1, 2020

This PR won't work as is until gofrs/flock#40 is merged.
However, it's possible in go.mod to specify a local directory in GOPATH to replace a Go module.
Therefore, once this PR has been merged, you can make it work on AIX by:

@urso
Copy link

urso commented Apr 1, 2020

Instead of adding more OSes to the _other files, I would prefer to change the build tag to +build !windows. So far it's the only OS that requires "more" special treatment. WDYT?

@Helflym
Copy link
Contributor Author

Helflym commented Apr 1, 2020

Sure, that's a better idea as new patches won't be needed everytime a new OS appears. I'll make the changes

@urso urso merged commit 9ce8ca6 into elastic:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants