-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: CI use orka for macos agents #56
Conversation
3101d2b
to
b71280b
Compare
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove support for 1.17
since it's not supported based on the CI results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also reported some of the errors I managed to find when I enabled the MacOS GitHub action, see #55
I don't know if this project is still active, if you discover any errors that are not related to 1.17
, I'd say to raise a GitHub issue with those details, so the project owner can prioritise it accordingly
Co-authored-by: Victor Martinez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minor comment regarding the description since 1.17
is not in the supported list in the CI at the moment
We are in the transition to use ephemeral workers.
TL;DR
Moved macos build from github actions to the martix build with orka in Jenkinsfile
MacOS will build with go 1.17 only