Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DB2 CLI libraries #385

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add DB2 CLI libraries #385

wants to merge 6 commits into from

Conversation

kuisathaverat
Copy link
Contributor

Add DB2 CLI libraries

@kuisathaverat kuisathaverat added the enhancement New feature or request label Jan 25, 2024
@kuisathaverat kuisathaverat self-assigned this Jan 25, 2024
Copy link

mergify bot commented Jan 25, 2024

This pull request does not have a backport label. Could you fix it @kuisathaverat? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@kuisathaverat
Copy link
Contributor Author

The pipeline is failing in with_mage in the .buildkite/scripts/build.sh. This failure is not related to my changes. The build is tested locally on my laptop and on an Ubuntu 22.04 VM, with the following command and works fine.

make -C go build

@kuisathaverat
Copy link
Contributor Author

@pazone Could you contact the owners of the BK pipeline?

@pazone
Copy link
Contributor

pazone commented Jan 26, 2024

@kuisathaverat #386 fixes the issue

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kuisathaverat

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kuisathaverat

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kuisathaverat

@@ -77,6 +77,11 @@ RUN curl -sSLO https://storage.googleapis.com/obs-ci-cache/beats/WpdPack_4_1_2.z
--output-lib /libpcap/win/WpdPack/Lib/x64/libwpcap.a \
--input-def /libpcap/win/WpdPack/wpcap.def

RUN go install github.com/ibmdb/go_ibm_db/[email protected] \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • As the driver library version is hardcoded here. Is there a way we could remove the dependency and use the latest version?
  • I don't think it would be possible as we run the setup script below by locating the installation folder. Just to check if its possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants