Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.23.0 #436

Merged
merged 97 commits into from
Aug 29, 2024
Merged

Update to Go 1.23.0 #436

merged 97 commits into from
Aug 29, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 14, 2024

Requires #435
Then we can branch off main and
Merge this PR.

Steps explained in https://github.com/elastic/golang-crossbuild#releasing-images-for-a-new-go-version

Implementation details

  • Bump version.
  • Remove install-go.sh and use native dockerfile commands to install golang for x86 - that's the case for ARM.
  • Update bump automation to avoid bumping changes in install-go.sh
  • Update docs.

@kruskall , do you mind adding some notes regarding the changes you did to fix the below two issues:

  • can't start telemetry child process: fork/exec /usr/local/go/bin/go: invalid argument
  • go: error obtaining buildID for go tool compile: fork/exec /usr/local/go/pkg/tool/linux_arm64/compile: invalid argument

@v1v v1v requested a review from a team August 14, 2024 18:13
@v1v v1v self-assigned this Aug 14, 2024
Copy link

mergify bot commented Aug 14, 2024

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@v1v v1v changed the title bump 1.23.0 Update to Go 1.23.0 Aug 14, 2024
Copy link

mergify bot commented Aug 15, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/bump-1.23 upstream/feature/bump-1.23
git merge upstream/main
git push upstream feature/bump-1.23

@kruskall
Copy link
Member

@v1v the error is at https://github.com/golang/telemetry/blob/0693e6240b9b888df93a2e280a64431c10d47a63/start.go#L233
the child process is not started if telemetry is disabled.
By default telemetry is running but it doesn't do any upload so it's ""off"". To turn it completely off we can follow https://go.dev/doc/telemetry but we need to go command to disable telemetry to run the go command. The hack is to disable telemetry manually by creating the config file and adding off to it.

This seems to get further in the build step but the CI still fails for another error:

go: error obtaining buildID for go tool compile: fork/exec /usr/local/go/pkg/tool/linux_arm64/compile: invalid argument

not sure what's going on here 🤔

@v1v
Copy link
Member Author

v1v commented Aug 26, 2024

Thanks, @kruskall, for your contribution.

I'm unsure what's happening with the error, but it seems related to running the cross-compile for arm on x86.

@kruskall
Copy link
Member

All checks have passed
10 successful checks

go/base/Dockerfile.tmpl Outdated Show resolved Hide resolved
@v1v v1v mentioned this pull request Aug 28, 2024
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@@ -45,9 +45,3 @@ find "go" -type f -name Dockerfile.tmpl -print0 |
${SED} -E -e "s#(ARG GOLANG_DOWNLOAD_SHA256)=.+#\1=${GOLANG_DOWNLOAD_SHA256_AMD}#g" "$line"
fi
done

if [ -e go/base/install-go.sh ] ; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use this file anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#496 is the follow-up.

@v1v v1v requested a review from cmacknz August 28, 2024 10:42
@v1v v1v enabled auto-merge (squash) August 28, 2024 10:42
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@pierrehilbert pierrehilbert requested a review from mauri870 August 29, 2024 10:45
@v1v v1v merged commit a20e3ab into elastic:main Aug 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants