-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.23.0 #436
Update to Go 1.23.0 #436
Conversation
This pull request does not have a backport label. Could you fix it @v1v? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
* upstream/main: 1.22.6 was not updated correctly (elastic#435)
@v1v the error is at https://github.com/golang/telemetry/blob/0693e6240b9b888df93a2e280a64431c10d47a63/start.go#L233 This seems to get further in the build step but the CI still fails for another error:
not sure what's going on here 🤔 |
Thanks, @kruskall, for your contribution. I'm unsure what's happening with the error, but it seems related to running the cross-compile for |
💚 Build Succeeded
History
cc @v1v |
💚 Build Succeeded
History
cc @v1v |
@@ -45,9 +45,3 @@ find "go" -type f -name Dockerfile.tmpl -print0 | | |||
${SED} -E -e "s#(ARG GOLANG_DOWNLOAD_SHA256)=.+#\1=${GOLANG_DOWNLOAD_SHA256_AMD}#g" "$line" | |||
fi | |||
done | |||
|
|||
if [ -e go/base/install-go.sh ] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't use this file anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#496 is the follow-up.
💚 Build Succeeded
History
cc @v1v |
Requires #435
Then we can branch off
main
andMerge this PR.
Steps explained in https://github.com/elastic/golang-crossbuild#releasing-images-for-a-new-go-version
Implementation details
install-go.sh
and use native dockerfile commands to install golang for x86 - that's the case for ARM.install-go.sh
@kruskall , do you mind adding some notes regarding the changes you did to fix the below two issues:
can't start telemetry child process: fork/exec /usr/local/go/bin/go: invalid argument
go: error obtaining buildID for go tool compile: fork/exec /usr/local/go/pkg/tool/linux_arm64/compile: invalid argument