Add support for Golang 1.15.4 #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
💔 Build Failed
Expand to view the summary
Build stats
Steps errors
Expand to view the steps failures
|
kuisathaverat
approved these changes
Nov 10, 2020
|
I see some failures in the publishing |
v1v
requested changes
Nov 10, 2020
There was a problem hiding this comment.
I see some failures in the publishing stage
[2020-11-09T16:30:17.820Z] echo ">> Pushing docker.elastic.co/observability-ci/golang-crossbuild:1.13.10-mips"
[2020-11-09T16:30:17.820Z] >> Pushing docker.elastic.co/observability-ci/golang-crossbuild:1.13.10-mips
[2020-11-09T16:30:17.820Z] The push refers to repository [docker.elastic.co/observability-ci/golang-crossbuild]
[2020-11-09T16:30:17.820Z] tag does not exist: docker.elastic.co/observability-ci/golang-crossbuild:1.13.10-mips
[2020-11-09T16:30:17.820Z] ..//../Makefile.common:9: recipe for target 'push' failed
[2020-11-09T16:30:17.820Z] make[2]: *** [push] Error 1
[2020-11-09T16:30:17.820Z] make[2]: Leaving directory '/var/lib/jenkins/workspace/eats_golang-crossbuild-mbp_PR-68/src/github.com/elastic/golang-crossbuild/go1.13/mips'
[2020-11-09T16:30:17.820Z] Makefile:8: recipe for target 'push' failed
[2020-11-09T16:30:17.820Z] make[1]: *** [push] Error 1
|
You can use the CLI $ curl -s 'https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/pipelines/golang-crossbuild-mbp/branches/PR-68/runs/1/nodes/104/log/?start=0' | grep failed -B 5And I see another one when building the docker image: |
|
Thanks I will look into the problem. |
|
For the record, I ran the some CLI for the master build and I did not see any failures: $ curl -s 'https://beats-ci.elastic.co/job/Beats/job/golang-crossbuild-mbp/job/master/16/consoleText' | grep failed I'm working on populating the errorlevel to the CI since it seems the current makefiles are not doing it -> #69 |
|
It seems that my changes are unrelated to the issue you have described according to #69 |
|
There are still some failures: $ curl -s 'https://beats-ci.elastic.co/job/Beats/job/golang-crossbuild-mbp/job/PR-68/2/consoleText' | grep failed
[2020-11-10T10:03:36.643Z] ../Makefile.common:13: recipe for target 'build' failed
[2020-11-10T10:03:36.643Z] Makefile:4: recipe for target 'build' failed
[2020-11-10T10:12:04.547Z] ../Makefile.common:13: recipe for target 'build' failed
[2020-11-10T10:12:04.547Z] Makefile:4: recipe for target 'build' failed
[2020-11-10T10:20:07.881Z] ../Makefile.common:13: recipe for target 'build' failed
[2020-11-10T10:20:07.881Z] Makefile:4: recipe for target 'build' failed
[2020-11-10T10:24:49.511Z] ../Makefile.common:13: recipe for target 'build' failed
[2020-11-10T10:24:49.511Z] Makefile:4: recipe for target 'build' failed
[2020-11-10T10:25:01.375Z] ../Makefile.common:13: recipe for target 'build' failed
[2020-11-10T10:25:01.376Z] Makefile:4: recipe for target 'build' failed
[2020-11-10T10:25:13.749Z] ../Makefile.common:13: recipe for target 'build' failed
[2020-11-10T10:25:13.749Z] Makefile:4: recipe for target 'build' failed
[2020-11-10T10:58:09.080Z] ..//../Makefile.common:9: recipe for target 'push' failed
[2020-11-10T10:58:09.080Z] Makefile:8: recipe for target 'push' failed
[2020-11-10T11:05:49.650Z] ..//../Makefile.common:9: recipe for target 'push' failed
[2020-11-10T11:05:49.650Z] Makefile:8: recipe for target 'push' failed
[2020-11-10T11:13:23.668Z] ..//../Makefile.common:9: recipe for target 'push' failed
[2020-11-10T11:13:23.668Z] Makefile:8: recipe for target 'push' failed |
|
jenkins run the tests please |
|
These two issues resolve all architecture and package issues we have, we only have to update them to the new go version, I suggest to close this PR and allow us to bump the go version and merge #62 to resolve the primary issue here, and them re-work and merge #65 to create one Docker image by architecture, now we are mixing little-endian, endia-little, 64bits, and 32bit architectures in the same container |
kvch
force-pushed
the
update-golang-to-1.15.4
branch
from
4ddc5ca to
ed0b34e
Compare
Merged
|
I am closing it in favour of #72 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Golang 1.15
darwin/386is not supported anymore. Thus, I have dropped it from the new Makefile.