Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Network Policy - Additonnal Rule #1106

Closed
noe-charmet opened this issue Mar 16, 2021 · 1 comment · Fixed by #1111
Closed

Network Policy - Additonnal Rule #1106

noe-charmet opened this issue Mar 16, 2021 · 1 comment · Fixed by #1111
Labels
bug Something isn't working elasticsearch

Comments

@noe-charmet
Copy link

Chart version: 7.12

Describe the bug:

In the NetworkPolicy definition, .Values.networkPolicy.transport.additionalRules is used in both the http and transport blocks. The http block should use .Values.networkPolicy.http.additionalRules as defined in the values.yaml file.

Problematic line:

helm-charts/elasticsearch/templates/networkpolicy.yaml

Line 31 in 90f71e7

{{- with .Values.networkPolicy.transport.additionalRules }}

@jmlrt jmlrt mentioned this issue Mar 17, 2021
Merged
jmlrt added a commit to jmlrt/helm-charts that referenced this issue Mar 17, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules
1063385 
This commit fix http additional rules to use with `NetworkPolicies`.

Fix elastic#1106
@jmlrt
Copy link
Member

jmlrt commented Mar 17, 2021

Hi @noe-charmet, thanks for reporting it, will be fixed in #1111

@jmlrt jmlrt added bug Something isn't working elasticsearch labels Mar 17, 2021
jmlrt added a commit that referenced this issue Mar 17, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (#1111)
c5e42ed 
* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix #1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
jmlrt added a commit to jmlrt/helm-charts that referenced this issue May 25, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (elastic#1111
d6c1306 
)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix elastic#1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
jmlrt added a commit to jmlrt/helm-charts that referenced this issue May 25, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (elastic#1111
501066e 
)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix elastic#1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
jmlrt added a commit to jmlrt/helm-charts that referenced this issue May 25, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (elastic#1111
3c4c694 
)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix elastic#1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
jmlrt added a commit that referenced this issue May 28, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (#1111) (#…
64f5174 
…1207)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix #1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
jmlrt added a commit that referenced this issue May 28, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (#1111) (#…
54fde15 
…1208)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix #1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
jmlrt added a commit that referenced this issue May 28, 2021
@jmlrt
[elasticsearch] fix network policies http additional rules (#1111) (#…
e5e4907 
…1209)

* [elasticsearch] fix network policies http additional rules

This commit fix http additional rules to use with `NetworkPolicies`.

Fix #1106

* [elasticsearch] improve netpol tests

This commit adds some small improvements in network policies tests:
* update example Makefile to fix commands and use similar structure to
other examples Makefiles
* fix example values file extension
* use different values for http and transport network policies in python
test and example values to catch regressions where same values would be
used for both
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[elasticsearch] fix network policies http additional rules jmlrt/helm-charts
2 participants
@jmlrt @noe-charmet