Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

ability to add additional labels #212

Closed
tonymayflower opened this issue Jul 8, 2019 · 3 comments · Fixed by #339
Closed

ability to add additional labels #212

tonymayflower opened this issue Jul 8, 2019 · 3 comments · Fixed by #339
Assignees
Labels

Comments

@tonymayflower
Copy link
Contributor

tonymayflower commented Jul 8, 2019

Describe the feature:
We need to add additional labels for monitoring into the daemonset as it's the case for podAnnotation.
Describe a specific use case for the feature:
Monitoring for prometheus, Service mesh ( istio), are based on the label.

PR should come from me !!

@Crazybus
Copy link
Contributor

Crazybus commented Jul 8, 2019

PR should come from me !!

Awesome! I just merged in the first version of the metricbeat chart in #127. Could you also add the additonal labels into it as well? The charts are very very similar so it should just be a matter of copy paste.

@tonymayflower
Copy link
Contributor Author

cf la PR : #214

@Crazybus
Copy link
Contributor

Crazybus commented Jul 9, 2019

Did you also plan on porting the same change to the metricbeat chart? If not I can pick that up.

@jmlrt jmlrt added the feature label Sep 23, 2019
@jmlrt jmlrt mentioned this issue Oct 22, 2019
4 tasks
@jmlrt jmlrt self-assigned this Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants