Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Add metricbeat chart #127

Merged
merged 15 commits into from
Jul 8, 2019
Merged

Add metricbeat chart #127

merged 15 commits into from
Jul 8, 2019

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented May 9, 2019 •
edited
Loading

The first commit is a copy paste of the filebeat chart. If you want to see all of the changes after the s/filebeat/metricbeat you can look at: https://github.com/elastic/helm-charts/pull/127/files/f8aa4bfaa972ac72abb017acb484ffbf457295d2..8bc136528dfb40ed3fd563edf9322708e6873447

Couple of notes:

  1. I don't really like the add/remove charts/ dance in .helmignore however I had to add it because helm lint --strict will fail because of linting problems with kube-state-metrics child chart. And leaving it in .helmignore will mean that helm can't find the child chart :(
  2. I made the decision for the metricbeat that uses kube-state-metrics to re-use the configmaps, secrets and extra envs from the daemonset. I did this because these secrets are always being used for the output to Elasticsearch. I couldn't imagine a situation where you would want to add a secret to one of them, but not the other. This simplifies the chart and removes a lot of duplication. The real reason we run a seperate deployment is so that we don't have each daemonset pod sending exactly the same information from the Kubernetes API. Since we theoretically could move the kube-state-metrics logic into the daemonset config (with the downside that you would have duplicated data and extra queries to the Kubernetes API) I can't see this causing any issues.
  3. I added in a couple of tests to make sure that the correct data really appears in Elasticsearch. This was to be sure that the daemonset metricbeat data and the deployment were making it in properly.

Crazybus added a commit that referenced this pull request May 9, 2019
@Crazybus
Add CI definitions for metricbeat chart
cc3b7c0 
This is being added to make sure that automated testing for the WIP
metricbeat chart is happening in #127
@Crazybus Crazybus mentioned this pull request May 9, 2019
Merged
jmlrt
jmlrt reviewed May 9, 2019
View reviewed changes
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first diff review between filebeat and metribeat charts LGTM

kimxogus pushed a commit to aroundus-inc/elastic-charts that referenced this pull request May 22, 2019
@Crazybus @kimxogus
Add CI definitions for metricbeat chart
55d4c94 
This is being added to make sure that automated testing for the WIP
metricbeat chart is happening in elastic#127
Crazybus added 10 commits July 1, 2019 13:31
@Crazybus
WIP: Add metricbeat chart
f8aa4bf 
Right now this is literally the filebeat chart with a
s/filebeat/metricbeat run over it and the default metricbeat.yml
changed. Since it was already working in this state I'm opening up a PR
so that it is easier to see the changes made versus filebeat and already
get CI testing it.
@Crazybus
Copy in all of the missing fields from the daemonset
bc6a027
@Crazybus
Update description and beta disclaimer
0d2fc1f
@Crazybus
Fix up linting and tests
4f41c6c 
`helm lint` also tries to lint subcharts. So the makefile now adds
`charts/` to the .helmignore before running the linting then adds it
back when adding the dependency.
@Crazybus
Update goss testing to support testing multiple containers
6b5cd0c
@Crazybus
Add tests to make sure that data is flowing in
a31fed0
@Crazybus
Add 6.x example
fa00f3d
@Crazybus
Add oss example
6ac4ffd
@Crazybus
Add security example
a71ece6
@Crazybus
Rebase on master and bump to latest version
1e90f5e
@Crazybus Crazybus force-pushed the metric_is_the_future branch from b7754fa to 1e90f5e Compare July 1, 2019 11:33
@Crazybus Crazybus changed the title WIP: Add metricbeat chart Add metricbeat chart Jul 1, 2019
@Crazybus Crazybus requested a review from jmlrt July 1, 2019 12:05
@Crazybus
Copy link
Contributor Author

Crazybus commented Jul 1, 2019

Just realised the CI changes won't work in this PR since they are only deployed from master. I just deployed the changes from this branch to devops-ci.

jenkins test this please

@Crazybus Crazybus requested review from tylerjl and removed request for jmlrt July 3, 2019 16:20
@Crazybus
Copy link
Contributor Author

Crazybus commented Jul 5, 2019

jenkins test this please

tylerjl
tylerjl approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart and all the caveats you mention LGTM - I agree about firing some ES queries to confirm data is flowing as expected; I think the queries are generic enough that they shouldn't be brittle or problematic between versions. 👍

@Crazybus Crazybus merged commit cc1de5e into master Jul 8, 2019
@Crazybus Crazybus deleted the metric_is_the_future branch July 8, 2019 09:52
@Crazybus Crazybus mentioned this pull request Jul 8, 2019
Closed
jmlrt added a commit that referenced this pull request Nov 17, 2020
@jmlrt
Helm 3 (#516)
d4e9f6b 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to #127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 17, 2020
@jmlrt
Helm 3 (elastic#516)
f29459b 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 17, 2020
@jmlrt
Helm 3 (elastic#516)
27d509e 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
This was referenced Nov 17, 2020
Merged
Merged
jmlrt added a commit that referenced this pull request Nov 18, 2020
@jmlrt
Helm 3 (#516) (#902)
2107d56 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to #127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
jmlrt added a commit that referenced this pull request Nov 18, 2020
@jmlrt
Helm 3 (#516) (#904)
faf0331 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to #127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
galina-tochilkin pushed a commit to mtp-devops/3d-party-helm that referenced this pull request Dec 20, 2022
@jmlrt
Helm 3 (#516)
e46ea17 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic/helm-charts#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
galina-tochilkin pushed a commit to mtp-devops/3d-party-helm that referenced this pull request Dec 20, 2022
@jmlrt
Helm 3 (#516) (#904)
ad1373b 
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic/helm-charts#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmlrt jmlrt jmlrt left review comments

@tylerjl tylerjl tylerjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Crazybus @tylerjl @jmlrt