Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Support fullnameOverride (Kibana chart) #267

Closed
ppawel opened this issue Aug 30, 2019 · 4 comments
Closed

Support fullnameOverride (Kibana chart) #267

ppawel opened this issue Aug 30, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@ppawel
Copy link

ppawel commented Aug 30, 2019

Describe the feature:

Currently "fullname" helper macro provides name to service, ingress etc. and it uses release name, chart name (and optionally you can input "nameOverride") and this results in a "x-y" construct.

Allowing the user to specify fullnameOverride in values file will give additional flexibility with naming resources.

Examples:

https://github.com/helm/charts/blob/master/stable/grafana/templates/_helpers.tpl
https://github.com/helm/charts/blob/master/stable/prometheus/templates/_helpers.tpl

Describe a specific use case for the feature:

I want my service, ingress and other resources to be named just "kibana", without any prefix, like "monitoring-kibana" (because they are anyway in the "monitoring" namespace in my case so it's redundant).

@davispw
Copy link

davispw commented Sep 21, 2019

This is inconsistent with elasticsearch's helm chart (which does not use the Release name at all--the service is always just named "elasticsearch-master").

@jmlrt jmlrt added the enhancement New feature or request label Sep 23, 2019
@morganchristiansson
Copy link
Contributor

I agree. My pod names are:

  • kibana-kibana-xxx
  • filebeat-filebeat-xxx
  • metricbeat-metricbeat-xxx

Please fix-fix

tusciucalecs pushed a commit to tusciucalecs/helm-charts that referenced this issue Oct 15, 2019
tusciucalecs pushed a commit to tusciucalecs/helm-charts that referenced this issue Oct 15, 2019
tusciucalecs pushed a commit to tusciucalecs/helm-charts that referenced this issue Oct 15, 2019
tusciucalecs added a commit to tusciucalecs/helm-charts that referenced this issue Oct 15, 2019
tusciucalecs added a commit to tusciucalecs/helm-charts that referenced this issue Oct 15, 2019
jmlrt added a commit that referenced this issue Nov 18, 2019
[Issue #267] Support fullnameOverride in kibana, filebeat, metricbeat…
@jmlrt
Copy link
Member

jmlrt commented Nov 21, 2019

I'm closing this issue as it was implemented in #330

@jmlrt jmlrt closed this as completed Nov 21, 2019
@ppawel
Copy link
Author

ppawel commented Nov 22, 2019

Thanks @tusciucalecs, you are a hero-hero!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants