Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] add emptyDir volume for kibana data #1196

Closed
wants to merge 1 commit into from
Closed

[kibana] add emptyDir volume for kibana data #1196

wants to merge 1 commit into from

Conversation

ebuildy
Copy link
Contributor

@ebuildy ebuildy commented May 24, 2021

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Use an emptyDir to store Kibana data instead of Docker overlay, this is a good practice, by setting security context readOnlyRootFilesystem : true .

User can set securityContext via value.yaml file.

(we do that for every Helm releases, elasticsearch/APM/logstash and Kibana, so I can create PR for each if this is a good idea of course).

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Member

jmlrt commented Jun 23, 2021

jenkins test this please

@ebuildy
Copy link
Contributor Author

ebuildy commented Jun 24, 2021

actually, with #1247 PR (extraVolumes), I think we dont need this one any more.

Give a values example should be enough

@jmlrt jmlrt added kibana enhancement New feature or request labels Jul 6, 2021
@botelastic
Copy link

botelastic bot commented Oct 4, 2021

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@botelastic
Copy link

botelastic bot commented Nov 12, 2021

This PR has been automatically closed because it has not had recent activity since being marked as stale. Please reopen when work resumes.

@botelastic botelastic bot closed this Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants