Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Fix for volumemounts indents and also added the serviceAccount feature from kibana as have a need for it #144

Closed
wants to merge 2 commits into from

Conversation

jamestutton
Copy link

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Crazybus
Copy link
Contributor

Crazybus commented Jun 3, 2019

Thanks for working on and fixing this! I'm planning to add a complex example to the automated example tests to make sure we can test all of these sorts of features and be sure that they are configured properly. Right now the integration tests only focus on testing the features used by the default install.

@acondrat
Copy link

Would really like to see it merged! @jamestutton this looks like a very simple and straightforward fix. Do you plan to submit it anytime soon?

Thanks!

@jmlrt
Copy link
Member

jmlrt commented Oct 1, 2019

Hello @jamestutton,
Thank for your PR.
I'll close it as extraVolumes was fixed in #245 and Service Account was implemented in another way in #265.

@jmlrt jmlrt closed this Oct 1, 2019
@jmlrt jmlrt self-assigned this Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants