Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] Add subPath support to secretMounts #230

Merged
merged 1 commit into from
Jul 23, 2019
Merged

[kibana] Add subPath support to secretMounts #230

merged 1 commit into from
Jul 23, 2019

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented Jul 22, 2019 •
edited
Loading

Fixes: #229

This is needed in situation where you need to mount a specific secret as
a file in a directory that contains other files. This was added for the
Elasticsearch chart to make it possible to mount the keystore, the same
option is needed for Kibana too as seen in in #229.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@Crazybus Crazybus force-pushed the yellow_subpathmarine branch from eee888a to c98d1c7 Compare July 22, 2019 15:05
@Crazybus Crazybus requested a review from tylerjl July 22, 2019 15:05
@Crazybus Crazybus mentioned this pull request Jul 22, 2019
Closed
@Crazybus
Copy link
Contributor Author

Build failures are from the GitHub outage:

17:35:41 kubectl exec $GOSS_CONTAINER -- sh -c "cd /tmp/ && curl -s -L https://github.com/aelsabbahy/goss/releases/download/v0.3.6/goss-linux-amd64 -o goss && chmod +rx ./goss && ./goss --gossfile goss.yaml validate --retry-timeout 300s --sleep 5s --color --format documentation"
17:35:42 Testing with pod: helm-kibana-default-kibana-86b99b88bb-stnbn
17:35:43 ./goss: line 1: syntax error near unexpected token `newline'
17:35:43 ./goss: line 1: `<!DOCTYPE html>'
17:35:43 command terminated with exit code 2

jenkins test this please

tylerjl
tylerjl previously approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Might want to add a commented subPath key to Kibana's values.yaml since the README.md uses it as a reference for what's available to be set for secretMounts as well.

@Crazybus
[kibana] Add subPath support to secretMounts
df7118b 
Fixes: #229

This is needed in situation where you need to mount a specific secret as
a file in a directory that contains other files. This was added for the
Elasticsearch chart to make it possible to mount the keystore, the same
option is needed for Kibana too as seen in in #229.
@Crazybus Crazybus force-pushed the yellow_subpathmarine branch from c98d1c7 to df7118b Compare July 23, 2019 13:02
@Crazybus
Copy link
Contributor Author

Changes LGTM. Might want to add a commented subPath key to Kibana's values.yaml since the README.md uses it as a reference for what's available to be set for secretMounts as well.

The example also showed the Elasticsearch paths which was even more confusing. Updated the example PTAL!

@Crazybus Crazybus requested a review from tylerjl July 23, 2019 13:04
tylerjl
tylerjl approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus Crazybus merged commit 1be55ba into master Jul 23, 2019
@Crazybus Crazybus deleted the yellow_subpathmarine branch July 23, 2019 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tylerjl tylerjl tylerjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kibana] Error when adding kibana-keystore as k8s secret mount
2 participants
@Crazybus @tylerjl