This repository has been archived by the owner on May 16, 2023. It is now read-only.
[metricbeat] use deprecated kube-state-metrics config when existing #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crazybus
suggested changes
May 18, 2020
|
jenkins test this please |
|
Helm isn't liking this character it seems |
Co-authored-by: Michael Russell <[email protected]>
…c.selector.matchLabels (elastic#622) This fix metricbeat chart upgrades when .Chart.Version change. UPGRADE FAILED Error: Deployment.apps "metricbeat-metricbeat-metrics" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"metricbeat-metricbeat-metrics", "chart":"metricbeat-7.7.0", "heritage":"Tiller", "release":"metricbeat"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable Error: UPGRADE FAILED: Deployment.apps "metricbeat-metricbeat-metrics" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"metricbeat-metricbeat-metrics", "chart":"metricbeat-7.7.0", "heritage":"Tiller", "release":"metricbeat"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable See helm/charts#7680 for more details
jmlrt
force-pushed
the
metricbeat-fix-deployment-config-upgrade
branch
from
cf83c61 to
4689c0c
Compare
…ricbeat.yml value This is requires because helm doesn't support accessing values with dash in the name (see helm/helm#2192 for more details).
This was really tricky but it's fixed by 235e4e4 (see helm/helm#2192 for more details). |
|
@Crazybus, this is fixed now. Can you recheck 🙏 ? |
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #623
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml