Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Support creating k8s helm secrets for logstash helm chart #705 #712

Merged
merged 8 commits into from
Jul 8, 2020
Merged

Support creating k8s helm secrets for logstash helm chart #705 #712

merged 8 commits into from
Jul 8, 2020

Conversation

kksudo
Copy link
Contributor

@kksudo kksudo commented Jul 5, 2020 •
edited
Loading

Describe the change
Added the helm chart for create secrets in k8s

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Linked issue

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 5, 2020 •
edited
Loading

💚 CLA has been signed

@kksudo
Copy link
Contributor Author

kksudo commented Jul 5, 2020

If it's make sense, I could prepare PR for the other elk helm charts (kibana etc)

@kksudo kksudo changed the title Feature/secrets support issue 705 Support creating k8s helm secrets for logstash helm chart #705 Jul 5, 2020
@kksudo
Copy link
Contributor Author

kksudo commented Jul 6, 2020

jenkins test this please

@kksudo
Copy link
Contributor Author

kksudo commented Jul 6, 2020

Jenkins test this please

@kksudo
Copy link
Contributor Author

kksudo commented Jul 6, 2020 •
edited
Loading

@jmlrt Could you run Jenkins pipeline please ?

@fatmcgav
Copy link
Contributor

fatmcgav commented Jul 7, 2020

Jenkins test this please

@fatmcgav fatmcgav added enhancement New feature or request logstash labels Jul 7, 2020
fatmcgav
fatmcgav reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@fatmcgav fatmcgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kksudo Thank you for taking the time to open this PR, and add some really good tests.

I've got a couple of small comments, but otherwise this is looking pretty solid.

logstash/README.md Outdated Show resolved Hide resolved
logstash/tests/logstash_test.py Outdated Show resolved Hide resolved
logstash/values.yaml Outdated Show resolved Hide resolved
@kksudo
Copy link
Contributor Author

kksudo commented Jul 7, 2020

@fatmcgav Could you run Jenkins pipeline again please ?

@kksudo kksudo requested a review from fatmcgav July 7, 2020 20:14
@fatmcgav
Copy link
Contributor

fatmcgav commented Jul 8, 2020

Jenkins test this please

@kksudo
Copy link
Contributor Author

kksudo commented Jul 8, 2020 •
edited
Loading

The Jenkins integration test was failing, command in pipeline can't install helm chart, without any error message. Could you describe, where is problem ?

09:57:48 Release "helm-logstash-default" does not exist. Installing it now.
10:12:49 Error: release helm-logstash-default failed: timed out waiting for the condition
10:12:49 make[1]: Leaving directory '/app/logstash/examples/default'
10:12:49 make[1]: *** [install] Error 1
10:12:49 make: *** [integration] Error 2

@fatmcgav
Copy link
Contributor

fatmcgav commented Jul 8, 2020

So that failure appears to be due to #663, rather than anything you've changed @kksudo, so no need to worry there...

fatmcgav
fatmcgav approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@fatmcgav fatmcgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatmcgav fatmcgav merged commit 917187d into elastic:master Jul 8, 2020
fatmcgav added a commit that referenced this pull request Jul 8, 2020
@kksudo @fatmcgav
Support creating k8s helm secrets for logstash helm chart #705 (#712)
665e1b2 
Co-authored-by: Gavin Williams <[email protected]>
fatmcgav added a commit that referenced this pull request Jul 8, 2020
@kksudo @fatmcgav
Support creating k8s helm secrets for logstash helm chart #705 (#712)
ce00c81 
Co-authored-by: Gavin Williams <[email protected]>
fatmcgav added a commit that referenced this pull request Jul 8, 2020
@kksudo @fatmcgav
Support creating k8s helm secrets for logstash helm chart #705 (#712)
303ad81 
Co-authored-by: Gavin Williams <[email protected]>
@kksudo kksudo deleted the feature/secrets-support-issue-705 branch July 8, 2020 10:22
@fatmcgav
Copy link
Contributor

fatmcgav commented Jul 8, 2020

Thanks for the contribution @kksudo

I've back-ported the changes onto the 7.8 and 6.8 release branches, so these changes will be included in the next patch releases of the logstash helm chart.

@jmlrt jmlrt removed the v7.9.0 label Jul 13, 2020
This was referenced Jul 16, 2020
Closed
Closed
This was referenced Jul 27, 2020
Merged
Merged
@erihanse erihanse mentioned this pull request Aug 13, 2020
Merged
4 tasks
@jmlrt jmlrt mentioned this pull request Sep 16, 2020
Closed
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
Closed
This was referenced Mar 15, 2021
Closed
Closed
@jmlrt jmlrt mentioned this pull request May 25, 2021
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
Merged
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
Merged
This was referenced Sep 14, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fatmcgav fatmcgav fatmcgav approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request logstash v6.8.11 v7.8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kksudo @elasticmachine @fatmcgav @jmlrt