7.9.3 snapshot #831
7.9.3 snapshot #831
Conversation
Bump chart version and Docker images to 7.9.3-SNAPSHOT to test 7.9.3 development version See [New branching model](https://github.com/elastic/helm-charts/blob/master/BREAKING_CHANGES.md#new-branching-model) for more details.
Do not hard code the version and provide instructions for both devel and released version.
apm-server/README.md
Outdated
| * Checkout the branch : `git checkout 7.9` | ||
|
|
||
| * Install it: | ||
| - with Helm 2: `helm install --name apm-server ./helm-charts/apm-server` |
There was a problem hiding this comment.
it should be specified in this section that it is also using snapshot docker images to avoid users confusion.
There was a problem hiding this comment.
Note that this already specified in https://github.com/elastic/helm-charts/pull/831/files#diff-ae72c3cb6c31c49e02d8b7896a43c68fR44:
This chart is tested with the latest 7.9.3-SNAPSHOT version.
However, that may not be clear enough for users
There was a problem hiding this comment.
we may add --set imageTag=<version> in the command...
|
|
||
| * Checkout the branch : `git checkout 7.9` |
There was a problem hiding this comment.
good point, this was missing previously 👍
apm-server/README.md
Outdated
| ### Install development version from a branch | ||
|
|
||
| * Clone the git repo: `git clone [email protected]:elastic/helm-charts.git` | ||
|
|
||
| * Checkout the branch : `git checkout 7.9` | ||
|
|
||
| * Install it: | ||
| - with Helm 2: `helm install --name apm-server ./helm-charts/apm-server` | ||
| - with [Helm 3 (beta)][]: `helm install apm-server ./helm-charts/apm-server` |
There was a problem hiding this comment.
What is the point of removing the 7.9.3-SNAPSHOT from this section.
Should we expect not removing it from the readme when doing releases?
There was a problem hiding this comment.
it wasn't in the original instructions - i'll add it
There was a problem hiding this comment.
Oh yes, it seems it was added in the previous pr but not in the doc 👍
nkammah
force-pushed
the
7.9.3-SNAPSHOT
branch
from
a128b86 to
1fd0183
Compare
This commit update charts readme to remove the version from the dev install section title. This is required to simplify bumping automation and avoid having to manage toc update. This was done in 7.9 branch in elastic#831
This commit update charts readme to remove the version from the dev install section title. This is required to simplify bumping automation and avoid having to manage toc update. This was done in 7.9 branch in elastic#831 Also remove a unused link
This commit update charts readme to remove the version from the dev install section title. This is required to simplify bumping automation and avoid having to manage toc update. This was done in 7.9 branch in #831 Also remove a unused link
Bump chart version and Docker images to 7.9.3-SNAPSHOT to test 7.9.3 development version
See New branching model for more details.