-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[elasticsearch][kibana] Add flexible ingress #994
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
cla/check |
jenkins test this please |
Co-authored-by: Julien Mailleret <[email protected]>
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we need to keep backward compatibility => added in ae0d168
jenkins test this please |
Co-authored-by: Julien Mailleret <[email protected]>
Co-authored-by: Julien Mailleret <[email protected]>
With no changes to our values, this change broke our Helm release. Is it the case that this chart does not follow semantic versioning? I would have expected a major version bump for this breaking change. I would also expect the breaking change to be listed here: https://github.com/elastic/helm-charts/blob/master/BREAKING_CHANGES.md#7111 |
Hi @yurrriq, |
Unfortunately, that is not the case. The breaking change is here, where the schema for |
I have created #1090 |
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml
Fix #979