Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SQS queue global setting #10672

Merged

Conversation

chemamartinez
Copy link
Contributor

@chemamartinez chemamartinez commented Jul 31, 2024

Proposed commit message

Recent tests and reports have revealed that using the same SQS queue for multiple data streams results in data loss even with a very low event load.

For this reason, this pull request updates the affected integrations by forcing users to configure a separate SQS queue for each enabled data stream, as well as updating the related documentation for their knowledge.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chemamartinez chemamartinez added Integration:carbon_black_cloud VMware Carbon Black Cloud Integration:cloudflare_logpush Cloudflare Logpush bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Integration:jamf_protect Jamf Protect labels Jul 31, 2024
@chemamartinez chemamartinez self-assigned this Jul 31, 2024
@chemamartinez chemamartinez marked this pull request as ready for review July 31, 2024 19:27
@chemamartinez chemamartinez requested a review from a team as a code owner July 31, 2024 19:27
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

elasticmachine commented Jul 31, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@chemamartinez chemamartinez requested a review from efd6 August 2, 2024 07:57
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chemamartinez

@chemamartinez chemamartinez merged commit bc2c24a into elastic:main Aug 6, 2024
5 checks passed
@elasticmachine
Copy link

Package carbon_black_cloud - 2.4.0 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud

@elasticmachine
Copy link

Package cloudflare_logpush - 1.22.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

@elasticmachine
Copy link

Package jamf_protect - 2.3.0 containing this change is available at https://epr.elastic.co/search?package=jamf_protect

jvalente-salemstate pushed a commit to jvalente-salemstate/integrations that referenced this pull request Aug 21, 2024
Recent tests and reports have revealed that using the same SQS queue for multiple data streams results in data loss even with a very low event load.

For this reason, this pull request updates the affected integrations by forcing users to configure a separate SQS queue for each enabled data stream, as well as updating the related documentation for their knowledge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:carbon_black_cloud VMware Carbon Black Cloud Integration:cloudflare_logpush Cloudflare Logpush Integration:jamf_protect Jamf Protect Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants