-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws_logs] Move default_region configuration from the advanced options #11676
[aws_logs] Move default_region configuration from the advanced options #11676
Conversation
Signed-off-by: Tetiana Kravchenko <[email protected]>
@@ -81,7 +81,7 @@ vars: | |||
title: Default AWS Region | |||
multi: false | |||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: check if it should be changed to true
💚 Build Succeeded
|
Quality Gate passedIssues Measures |
changes: | ||
- description: Move default_region configuration from the advanced options | ||
type: bugfix | ||
link: https://github.com/elastic/integrations/pull/10789 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link: https://github.com/elastic/integrations/pull/10789 | |
link: https://github.com/elastic/integrations/pull/11676 |
@tetianakravchenko I created a PR in Beats to fix the bug that causes this behavior. Maybe we should keep default_region in the advanced option still. |
@kaiyan-sheng ok, lets keep default_region in advanced option, closing this PR then |
Proposed commit message
Please explain:
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots