Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws_logs] Move default_region configuration from the advanced options #11676

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Nov 8, 2024

Proposed commit message

Please explain:

  • WHAT: Move default_region configuration to the main configuration section from the advanced options
  • WHY: the download of objects (S3 polling) is silently failing without default_region set

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2024-11-08 at 17 36 44

@tetianakravchenko tetianakravchenko requested a review from a team as a code owner November 8, 2024 16:37
@@ -81,7 +81,7 @@ vars:
title: Default AWS Region
multi: false
required: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: check if it should be changed to true

@andrewkroh andrewkroh added Integration:aws_logs Custom AWS Logs Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Nov 8, 2024
@elasticmachine
Copy link

💚 Build Succeeded

changes:
- description: Move default_region configuration from the advanced options
type: bugfix
link: https://github.com/elastic/integrations/pull/10789
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/10789
link: https://github.com/elastic/integrations/pull/11676

@kaiyan-sheng
Copy link
Contributor

@tetianakravchenko I created a PR in Beats to fix the bug that causes this behavior. Maybe we should keep default_region in the advanced option still.

@tetianakravchenko
Copy link
Contributor Author

@tetianakravchenko I created a elastic/beats#41572 in Beats to fix the bug that causes this behavior. Maybe we should keep default_region in the advanced option still.

@kaiyan-sheng ok, lets keep default_region in advanced option, closing this PR then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:aws_logs Custom AWS Logs Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants