Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert kubernetes namespace field breaking change #2209

Conversation

MichaelKatsoulis
Copy link
Contributor

What does this PR do?

After agreement on #2165 and in continuation of merging elastic/beats#29069
this PR reverts the kubernetes.namespace field update in kubernetes integration as well.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@MichaelKatsoulis MichaelKatsoulis marked this pull request as draft November 23, 2021 11:47
@MichaelKatsoulis
Copy link
Contributor Author

After reverting the breaking change I think I should also revert the Kibana constraint to kibana.version: "^7.16.0 || ^8.0.0".

@MichaelKatsoulis MichaelKatsoulis marked this pull request as ready for review November 23, 2021 11:51
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reverted change modified 54 files (#1792), but this one modifies 53, is this expected?

@@ -10,7 +10,7 @@ categories:
- kubernetes
release: ga
conditions:
kibana.version: "^8.0.0"
kibana.version: "^7.16.0 || ^8.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-23T11:56:07.903+0000

  • Duration: 33 min 57 sec

  • Commit: 77f71bb

Test stats 🧪

Test Results
Failed 0
Passed 113
Skipped 0
Total 113

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@MichaelKatsoulis MichaelKatsoulis merged commit 1a89080 into elastic:master Nov 24, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Revert kubernetes namespace field breaking change

* Update changelog.yml

* Update the kibana constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants