Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panw: remove invalid field values from pipeline #3094

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 14, 2022

What does this PR do?

This removes two invalid field values from event.category. The valid values were already set so no replacement is required.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels Apr 14, 2022
@efd6 efd6 requested a review from a team as a code owner April 14, 2022 03:09
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-14T03:25:53.854+0000

  • Duration: 15 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

packages/panw/changelog.yml Outdated Show resolved Hide resolved
@efd6 efd6 merged commit 22c010f into elastic:main Apr 14, 2022
@efd6 efd6 mentioned this pull request May 11, 2022
4 tasks
efd6 added a commit to efd6/integrations that referenced this pull request May 11, 2022
This brings the searches into line with the changes made in elastic#3094. The granularity
of event fields is not fine enough within the panw integration to be able to replicate
the behaviour that previously existed, so the panw.panos.type field is used instead.
efd6 added a commit that referenced this pull request May 15, 2022
* panw: fix terms in saved search

This brings the searches into line with the changes made in #3094. The granularity
of event fields is not fine enough within the panw integration to be able to replicate
the behaviour that previously existed, so the panw.panos.type field is used instead.

* fix sample event and add to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panw using invalid field values according to ECS
3 participants