Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_asa] Add TCP input with TLS support #3312

Merged
merged 6 commits into from
May 12, 2022

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 10, 2022

What does this PR do?

  • Add TCP input, with TLS and custom options support
  • Add system test for TCP input

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_asa && elastic-package test

Related issues

Screenshots

cisco_asa

- Add TCP input, with TLS and custom options support
- Add system test for TCP input
@elasticmachine
Copy link

elasticmachine commented May 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:55:00.863+0000

  • Duration: 18 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 10, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.597
Classes 100.0% (1/1) 💚 3.597
Methods 94.444% (17/18) 👍 6.198
Lines 63.155% (1097/1737) 👎 -25.958
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review May 10, 2022 13:32
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 10, 2022 13:32
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see port clashes with other packages that use tcp|udp inputs that use syslog input (panw, checkpoint, pfsense) and a few more. Not sure if it would pose a problem but in rare cases it might if the user uses the default values.

@taylor-swanson
Copy link
Contributor Author

I see port clashes with other packages that use tcp|udp inputs that use syslog input (panw, checkpoint, pfsense) and a few more. Not sure if it would pose a problem but in rare cases it might if the user uses the default values.

Fair point. I haven't heard of any complaints about ports yet. That may be a good idea going forward, but maybe that'd best be handled in a separate issue with greater coordination between packages (and potentially teams).

@r00tu53r
Copy link
Contributor

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants