-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cisco_asa] Add TCP input with TLS support #3312
Conversation
- Add TCP input, with TLS and custom options support - Add system test for TCP input
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see port clashes with other packages that use tcp|udp
inputs that use syslog input (panw, checkpoint, pfsense
) and a few more. Not sure if it would pose a problem but in rare cases it might if the user uses the default values.
Fair point. I haven't heard of any complaints about ports yet. That may be a good idea going forward, but maybe that'd best be handled in a separate issue with greater coordination between packages (and potentially teams). |
LGTM! |
What does this PR do?
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots