Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_asa: remove invalid values from ECS fields #3354

Merged
merged 1 commit into from
May 16, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 16, 2022

What does this PR do?

This removes invalid values from the event.outcome field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_asa Cisco ASA labels May 16, 2022
@efd6 efd6 requested a review from a team as a code owner May 16, 2022 00:08
@efd6 efd6 self-assigned this May 16, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-16T01:10:31.556+0000

  • Duration: 16 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 force-pushed the 3344-cisco_asa branch from 303d33c to 35e4dab Compare May 16, 2022 01:10
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.448
Classes 100.0% (1/1) 💚 3.448
Methods 94.444% (17/18) 👍 5.848
Lines 63.155% (1097/1737) 👎 -25.771
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cisco_asa Cisco ASA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants