Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid ips used in tests #3410

Merged
merged 7 commits into from
May 31, 2022
Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 23, 2022

What does this PR do?

elastic-package only allows the use of IPs that have geoip data in the included geoip database (see elastic/elastic-package#605).

Fields validation is only done with the first element when the field contains an array. In elastic/elastic-package#771 we are introducing the check for all elements in the array, what will make these packages to fail.

There are IPs in arrays that are not allowed by this check. Replace them.

Related issues

@jsoriano
Copy link
Member Author

Will wait for elastic/elastic-package#826, to have more available ipv6 addresses, and to solve issues with addresses with leading zeroes.

@elasticmachine
Copy link

elasticmachine commented May 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-30T10:08:52.563+0000

  • Duration: 66 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 686
Skipped 0
Total 686

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 23, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (55/55) 💚
Files 95.146% (98/103) 👎 -1.35
Classes 95.146% (98/103) 👎 -1.35
Methods 86.127% (894/1038) 👎 -3.234
Lines 93.258% (16116/17281) 👍 2.482
Conditionals 100.0% (0/0) 💚

@jsoriano jsoriano force-pushed the remove-invalid-test-ips branch from b7d3c53 to 81e66fb Compare May 23, 2022 16:56
@jsoriano
Copy link
Member Author

Pending validation of IPv6 address will be fixed by elastic/elastic-package#826, opening this for review.

@jsoriano jsoriano marked this pull request as ready for review May 23, 2022 16:57
@jsoriano jsoriano requested review from a team as code owners May 23, 2022 16:57
@jsoriano jsoriano requested review from belimawr and kvch May 23, 2022 16:57
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where there are a number of IPv6 addresses in IP arrays and they are distinct and not in the first position (so not tagged as not-allowed under the current testing) I'd suggest to keep the distinctness so that they can be used to test fixes for allow_duplicates: false. This can be done with no loss of information by using RFC 4193 private IPs for those replacements.

@jsoriano
Copy link
Member Author

@efd6 thanks for the review! I will wait then for elastic/elastic-package#826 so we can have different ipv6 addresses, and address your comments.

@jsoriano jsoriano marked this pull request as draft May 24, 2022 13:18
@jsoriano jsoriano marked this pull request as ready for review May 30, 2022 11:27
@jsoriano
Copy link
Member Author

Open for review. @efd6 it'd be great if you could give it another look. Thanks!

@jsoriano jsoriano requested a review from a team May 30, 2022 11:28
@mtojek mtojek merged commit 7a73a3e into elastic:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages using IPs not allowed for testing
4 participants