Make Vsphere GA: Enabling Vsphere Metrics/Logs

[ishleenk17]

• Enhancement

What does this PR do?

This PR enables below things in Vsphere:

• Receiving metrics/logs in integration
• Addition of system tests
• Update on dashboards
• Update on fields.yml
• Support for new metrices

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Bring up the vcsim simulator on system and add integration. It should start the metrics flow to Kibana

Related issues

• Closes Make Vsphere GA #3508

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-07-22T06:34:54.737+0000

• Duration: 19 min 7 sec

Test stats 🧪

Test	Results
Failed	0
Passed	18
Skipped	0
Total	18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (1/1)	💚
Files	100.0% (1/1)	💚 2.941
Classes	100.0% (1/1)	💚 2.941
Methods	100.0% (18/18)	💚 10.749
Lines	89.796% (44/49)	👎 -0.787
Conditionals	100.0% (0/0)	💚

[muthu-mps]

The documentation could include the vSphere configuration details.

[ishleenk17]

The documentation could include the vSphere configuration details.

Yes, I am looking at what would be the best way to document this part.
As we are using simulator and those details need not be in the README necessarily.
Planning to have another doc in integration stating how we can bring up Vsphere.

[ManojS-shetty]

Can we have a single liner definitions for each data stream in README documentation file.?

[ishleenk17]

Can we have a single liner definitions for each data stream in README documentation file.?

good point. Done

[ishleenk17]

/test

[jsoriano]

This is looking good, added some small comments.

[lalit-satapathy]

Capturing offline review feedbacks/status:

1. Long term post-GA need integration test on a production vspshere installation(future)
2. Extra field not showing on beats sample event but on integration (future, let's file an beats issue for this)
3. Can we test the get_custom_fields manually once ( limitation of the simulator. )
4. Datastores to hosts change need to ensure it is working (done)
5. What is the secured way to connect to vsphere ( test both true/false insecure in vspehere). (verified by @ishleenk17)
6. fix readme link (done)
7. Improve field description (done).

LGTM!

[ishleenk17]

Capturing offline review feedbacks/status:

1. Long term post-GA need integration test on a production vspshere installation(future)
2. Extra field not showing on beats sample event but on integration (future, let's file an beats issue for this)
3. Can we test the get_custom_fields manually once ( limitation of the simulator. )
4. Datastores to hosts change need to ensure it is working (done)
5. What is the secured way to connect to vsphere ( test both true/false insecure in vspehere). (verified by @ishleenk17)
6. fix readme link (done)
7. Improve field description (done).

LGTM!

Links for the open issue:

• Vsphere Production level testing
• Test for Custom fields for Virtualmachine
• Check for network names presence in the sample event in beats

[muthu-mps]

LGTM!