Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Add GCP Custom Metricset #3794

Closed
wants to merge 2 commits into from

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jul 21, 2022

What does this PR do?

Add GCP Custom Metricset

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested review from a team as code owners July 21, 2022 15:22
@legoguy1000 legoguy1000 force-pushed the 490-gcp-custom-metrics branch from d12fefc to 1ed712e Compare July 21, 2022 15:22
@elasticmachine
Copy link

elasticmachine commented Jul 21, 2022

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-22T05:01:19.744+0000

  • Duration: 19 min 33 sec

Test stats 🧪

Test Results
Failed 1
Passed 47
Skipped 0
Total 48

Test errors 1

Expand to view the tests failures

static test: Verify sample_event.json – gcp.metrics
    Expand to view the error details

     null 
    

    Expand to view the stacktrace

     one or more errors found in document: [0] field "gcp.metrics.instance.uptime_total.value" is undefined 
    

Steps errors 1

Expand to view the steps failures

Test integration: gcp
  • Took 4 min 28 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jul 22, 2022

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 3.0
Classes 100.0% (4/4) 💚 3.0
Methods 92.754% (64/69) 👍 2.997
Lines 95.21% (1113/1169) 👍 3.679
Conditionals 100.0% (0/0) 💚

@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 1, 2022
@endorama
Copy link
Member

endorama commented Sep 8, 2022

👋 @legoguy1000 there have been some internal discussion around migrating the gcp.metrics metricset, I reported the conclusions here.

Due to those considerations, I'm going to close this PR. If you want to discuss our conclusions further feel free to comment on the linked issue.

Thanks a lot for your contribution, as usual! 💪

@endorama endorama closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GCP] Migrate gcp.metrics metricset to data stream
4 participants