Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PFsense] Fix Redundant Grok pattern #3969

Merged
merged 2 commits into from
Aug 11, 2022
Merged

[PFsense] Fix Redundant Grok pattern #3969

merged 2 commits into from
Aug 11, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Fix redundant Grok Pattern that causes "warning" messages in Elasticsearch logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner August 8, 2022 11:59
@elasticmachine
Copy link

elasticmachine commented Aug 8, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T13:01:56.958+0000

  • Duration: 18 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

r00tu53r
r00tu53r approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r00tu53r
Copy link
Contributor

r00tu53r commented Aug 8, 2022

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 88.889% (8/9) 👎 -8.249
Classes 88.889% (8/9) 👎 -8.249
Methods 91.667% (55/60) 👍 2.404
Lines 88.217% (554/628) 👎 -2.424
Conditionals 100.0% (0/0) 💚

@legoguy1000
Copy link
Contributor Author

@r00tu53r Ready to merge

@r00tu53r r00tu53r merged commit d104063 into elastic:main Aug 11, 2022
@legoguy1000 legoguy1000 deleted the 3955-pfsense-grok-bug branch August 11, 2022 14:11
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r00tu53r r00tu53r r00tu53r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pfsense: Redundant regex operation error in Elasticsearch
3 participants
@legoguy1000 @elasticmachine @r00tu53r