Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] Convert Oracle Performance Datastream to TSDB #4966

Closed
wants to merge 19 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated kibana minversion
agithomas committed Jan 23, 2023
commit 6b42bf512c3ba2478e5273c84955382d4488ee03
Original file line number Diff line number Diff line change
@@ -3,7 +3,6 @@
external: ecs
- name: data_stream.dataset
type: constant_keyword
# dimension: true
external: ecs
- name: data_stream.namespace
type: constant_keyword
1 change: 0 additions & 1 deletion packages/oracle/data_stream/performance/fields/ecs.yml
Original file line number Diff line number Diff line change
@@ -11,4 +11,3 @@
name: service.type
- external: ecs
name: host.name
# dimension: true
7 changes: 1 addition & 6 deletions packages/oracle/data_stream/performance/manifest.yml
Original file line number Diff line number Diff line change
@@ -25,9 +25,4 @@ streams:

elasticsearch:
index_mode: "time_series"
source_mode: "synthetic"
# routing_path: ["host.ip", "service.address"]
index_template:
settings:
# Defaults to 16
index.mapping.dimension_fields.limit: 16
source_mode: "synthetic"
2 changes: 1 addition & 1 deletion packages/oracle/manifest.yml
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ categories:
- infrastructure
release: ga
conditions:
kibana.version: "^8.3.0"
kibana.version: "^8.7.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the requirement bumped to 8.7.0? I'm aware the dimension part will not take affect before but I assume it works in the way that it is just ignored? Are there features inside here that don't work in 8.3.0?

Copy link
Contributor Author

@agithomas agithomas Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was specifically looking for TSDB enable-disable flag and hence 8.7.0.

Should TSDB be enabled by default or not? If yes, then enable /disable flag is important to give the user the option to use non-TSDB. If non-TSDB is the default, 8.3.0 is sufficient enough.

Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it throw an error if you have it in there and you try to install it in 8.3?

screenshots:
- src: /img/Oracle-overview-dashboard.png
title: Oracle overview dashboard