-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prototype] Convert Oracle Performance Datastream to TSDB #4966
Closed
+11,719
−5,556
Closed
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
21305e6
[Prototype] Convert Oracle Performance Datastream to TSDB
agithomas 08e4f2d
added additional field as dimension
agithomas ec93dba
Modified dimensions configuration
agithomas 3651ddd
Merge branch 'main' into issue-4848
agithomas a69e6ba
merged with main
agithomas c904de8
Merged with main
agithomas 4641a35
Merged with main
agithomas 6a20e23
Converted Kibana visualisation to Lens
agithomas b5ade92
Updated the screenshot of dashboard, dashboard using Lens
agithomas 6b42bf5
Updated kibana minversion
agithomas 1435521
Added additional dimension field
agithomas 349fb6a
Removed query field. Added query_id created by hashing query
agithomas 8e025a2
Added dimension fileds for memory datastream
agithomas f65eae3
Added updated memory dashboard
agithomas 962da35
Added timeseries type
agithomas 8975c00
Enabled TSDB for memory datastream
agithomas 8bf4264
Added tablespace lens changes, tsdb
agithomas 7e4d1f1
Lens migration completed. Datastream name included in filter conditio…
agithomas 8a57d6b
Fixed minor query issue
agithomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Updated kibana minversion
commit 6b42bf512c3ba2478e5273c84955382d4488ee03
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,4 +11,3 @@ | |
name: service.type | ||
- external: ecs | ||
name: host.name | ||
# dimension: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the requirement bumped to 8.7.0? I'm aware the dimension part will not take affect before but I assume it works in the way that it is just ignored? Are there features inside here that don't work in 8.3.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was specifically looking for TSDB enable-disable flag and hence 8.7.0.
Should TSDB be enabled by default or not? If yes, then enable /disable flag is important to give the user the option to use non-TSDB. If non-TSDB is the default, 8.3.0 is sufficient enough.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it throw an error if you have it in there and you try to install it in 8.3?