Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Logs] Fix authentication_processing_details parsing in sign-in logs #5129

Merged
merged 3 commits into from
Feb 7, 2023
Merged

[Azure Logs] Fix authentication_processing_details parsing in sign-in logs #5129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39d19ee
Fix authentication_processing_details parsing
zmoog Jan 27, 2023
4d03606
Update packages/azure/data_stream/signinlogs/elasticsearch/ingest_pip…
zmoog Jan 27, 2023
aeaf106
Add changelog
zmoog Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/azure/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@

- version: "1.5.7"
changes:
- description: Fix parsing of authentication_processing_details field in signin logs
type: bugfix
link: https://github.com/elastic/integrations/pull/5129
- version: "1.5.6"
changes:
- description: Fix parsing error client port is blank and adjust for timeStamp
Expand Down
90 changes: 15 additions & 75 deletions ...a_stream/signinlogs/_dev/test/pipeline/test-non-interactive-user-sample.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -159,11 +155,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -297,11 +289,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"AccessReview.ReadWrite.All\",\"AuditLog.Read.All\",\"Directory.AccessAsUser.All\",\"Directory.Read.All\",\"Directory.ReadWrite.All\",\"email\",\"EntitlementManagement.Read.All\",\"Group.ReadWrite.All\",\"IdentityProvider.ReadWrite.All\",\"IdentityRiskEvent.ReadWrite.All\",\"IdentityUserFlow.Read.All\",\"openid\",\"Policy.Read.All\",\"Policy.ReadWrite.AuthenticationFlows\",\"Policy.ReadWrite.AuthenticationMethod\",\"Policy.ReadWrite.ConditionalAccess\",\"profile\",\"Reports.Read.All\",\"RoleManagement.ReadWrite.Directory\",\"SecurityEvents.ReadWrite.All\",\"TrustFrameworkKeySet.Read.All\",\"User.Export.All\",\"User.ReadWrite.All\",\"UserAuthenticationMethod.ReadWrite.All\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -435,11 +423,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -574,11 +558,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -712,11 +692,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -850,11 +826,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -988,11 +960,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -1127,11 +1095,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"AccessReview.ReadWrite.All\",\"AuditLog.Read.All\",\"Directory.AccessAsUser.All\",\"Directory.Read.All\",\"Directory.ReadWrite.All\",\"email\",\"EntitlementManagement.Read.All\",\"Group.ReadWrite.All\",\"IdentityProvider.ReadWrite.All\",\"IdentityRiskEvent.ReadWrite.All\",\"IdentityUserFlow.Read.All\",\"openid\",\"Policy.Read.All\",\"Policy.ReadWrite.AuthenticationFlows\",\"Policy.ReadWrite.AuthenticationMethod\",\"Policy.ReadWrite.ConditionalAccess\",\"profile\",\"Reports.Read.All\",\"RoleManagement.ReadWrite.Directory\",\"SecurityEvents.ReadWrite.All\",\"TrustFrameworkKeySet.Read.All\",\"User.Export.All\",\"User.ReadWrite.All\",\"UserAuthenticationMethod.ReadWrite.All\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -1265,11 +1229,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -1403,11 +1363,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -1541,11 +1497,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -1679,11 +1631,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -1818,11 +1766,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down Expand Up @@ -1957,11 +1901,7 @@
"authentication_details": [],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[\"user_impersonation\"]"
},
"authentication_protocol": "none",
Expand Down
6 changes: 1 addition & 5 deletions ...a_stream/signinlogs/_dev/test/pipeline/test-non-interactive-user-signin.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,7 @@
],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Oauth Scope Info": "[User.Read,Userinfo.ReadWrite]"
},
"authentication_protocol": "none",
Expand Down
12 changes: 2 additions & 10 deletions .../azure/data_stream/signinlogs/_dev/test/pipeline/test-signinlogs-sample.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@
],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Login Hint Present": "True",
"Oauth Scope Info": ""
},
Expand Down Expand Up @@ -193,11 +189,7 @@
],
"authentication_processing_details": {
"Is CAE Token": "False",
"Legacy TLS (TLS 1": {
"0, 1": {
"1, 3DES)": "False"
}
},
"Legacy TLS (TLS 1.0, 1.1, 3DES)": "False",
"Login Hint Present": "True",
"Oauth Scope Info": ""
},
Expand Down
25 changes: 10 additions & 15 deletions packages/azure/data_stream/signinlogs/elasticsearch/ingest_pipeline/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,22 +190,17 @@ processors:
- remove:
field:
- azure.signinlogs.properties.location

ignore_missing: true
- foreach:
field: azure.signinlogs.properties.authentication_processing_details
ignore_missing: true
processor:
set:
field: '_tmp.{{{_ingest._value.key}}}'
copy_from: _ingest._value.value
- set:
if: ctx?._tmp != null
field: azure.signinlogs.properties.authentication_processing_details
copy_from: _tmp
- remove:
field: _tmp
ignore_missing: true
- script:
description: "Turns the authentication_processing_details array elements into key/value pairs. For example, the array element ``{key: 'key1', value: 'value1'}`` becomes ``{key1: 'value1'}``."
lang: painless
source: |
def tmp = [:];
for (item in ctx.azure.signinlogs.properties.authentication_processing_details) {
tmp[item.key] = item.value;
}
ctx.azure.signinlogs.properties.authentication_processing_details = tmp;
if: ctx.azure?.signinlogs?.properties?.authentication_processing_details != null && ctx.azure.signinlogs.properties.authentication_processing_details instanceof List
- set:
field: event.kind
value: event
Expand Down
2 changes: 1 addition & 1 deletion packages/azure/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: azure
title: Azure Logs
version: 1.5.6
version: 1.5.7
release: ga
description: This Elastic integration collects logs from Azure
type: integration
Expand Down